Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XO can award distinguished conduct medals #5131

Closed
wants to merge 11 commits into from

Conversation

ihatethisengine
Copy link
Contributor

@ihatethisengine ihatethisengine commented Dec 5, 2023

About the pull request

XO can award distinguished conduct medals.

Explain why it's good for the game

We already have an non-WLed role that can give out medals and it wasn't a big issue. LRP is already against the rules for XO, so why not? Arguably XO is more motivated to give out medals than CO (deployed and perma) and we don't have a CO every round, so I think it would be fine.

Testing Photographs and Procedure

Screenshots & Videos

2023-12-06_15-24-00

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 ihatethisengine
add: XO can award distinguished conduct medals.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Dec 5, 2023
@ihatethisengine ihatethisengine marked this pull request as ready for review December 5, 2023 12:23
@nauticall
Copy link
Contributor

nauticall commented Dec 7, 2023

DNM pending maintainer discussion. The uniqueness of COs being able to give medals is one of the more prevalent parts of the whitelist and we'll need to talk this over to see how that goes in the grand scheme of things.

To be clear, I'm not strictly against it. I just think this needs time in the oven for us to talk over. If it gets approved after the talks, that's fine with me.

@nauticall nauticall added the Do Not Merge If you merge this PR, I will annihilate you label Dec 7, 2023
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restrict the available medals XOs can give out to just the MARINE_CONDUCT_MEDAL

@ihatethisengine ihatethisengine changed the title XO can give out medals XO can give out distinguished conduct medals Dec 8, 2023
@ihatethisengine
Copy link
Contributor Author

Done

@ihatethisengine ihatethisengine changed the title XO can give out distinguished conduct medals XO can award distinguished conduct medals Dec 8, 2023
@c4xmaniac2

This comment was marked as off-topic.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Dec 12, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ghost
Copy link

ghost commented Dec 16, 2023

If the decision is reached that this is approved shouldn't 'Bronze Heart Medal' also be included since it is a lower status or at best an equal medal of 'Medal of Distinguished Conduct' ?

'Medal of Exceptional Heroism' and 'Medal Of Valor' should remain CO whitelisted awards as they are very grand awards but the other two medals seem perfectly acceptable for a Captain to hand out.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Dec 16, 2023
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Dec 24, 2023
@github-actions github-actions bot closed this Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge If you merge this PR, I will annihilate you Feature Feature coder badge Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants